Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tiles are empty on the Western U.S. #80

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Tiles are empty on the Western U.S. #80

wants to merge 4 commits into from

Conversation

shree665
Copy link

@shree665 shree665 commented Jul 12, 2018 •
edited
Loading

We have run into the issue that data is missing over the western U.S. We saw same issue when we open a layer using openLayer in GeoServer as well as in Leaflet. But the issue won't happen missing data over western U.S issue when we use postGis as a backend. So, I did the following changes to the code.

  • updated clipToWorld() method which seems to have a bug and returning empty tiles for West coast of USA
  • added elasticsearch connection timeout on rest client

I can provide script and leaflet html code to test the issue if needed.

Vivek Subedi added 2 commits July 12, 2018 10:49
- updated clipToWorld() method which seems to have bug and returning
711863f 
empty tiles for West coast of USA
- added elasticsearch connection timeout on rest client
- just a clean up
ad088e2
@shree665 shree665 changed the title Tiles are empty on the West cost of USA Tiles are empty on the Western U.S. Jul 12, 2018
sjudeng
sjudeng reviewed Jul 13, 2018
View reviewed changes
Copy link
Contributor

@sjudeng sjudeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. It looks like there are failures in some of the existing tests with the updates (see here). Can you take a look? Also can you add new test case(s) to cover the issue/fix?

@shree665
Copy link
Author

I have updated the failed tests. I think those two failed tests were wrong before. testBBOXCoveringDateline() test method should be asserted to one point because wifiAccessPoint.json only has one record which is inside the provided bounding box. On the other hand, testBBOXBeyondDateline() test method should be asserted to zero point. am I missing anything on those tests? It don't want to sound crazy here.

Please let me know if I need to do anything else.

@sjudeng
Copy link
Contributor

sjudeng commented Jul 19, 2018

Thanks for adding that test. testBBOXCoveringDateline is testing that both 45,179 and 45,-179 are included when the bbox crosses the dateline (e.g. 178, -98, 182, 98). Likewise testBBOXBeyondDateline is testing that the 45,-179 point is included when the bbox is on the other side of the dateline with coords in [0,360] instead of [-180,180] (e.g. 180.5, -98, 182, 98).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjudeng sjudeng sjudeng left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shree665 @sjudeng